Fix UseDurableOutboxOnAllSendingEndpoints() not applying to topic exchange endpoints#2386
Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom Mar 31, 2026
Merged
Conversation
…hange endpoints AllSenders() filtered endpoints by Subscriptions.Any(), which missed endpoints registered via PublishMessagesToRabbitMqExchange<T>() since TopicRouting uses routing sources instead of subscriptions. Messages sent to topic exchanges used InlineSendingAgent and were discarded after 3 failed attempts instead of being persisted to the outbox. Add IEndpointSource interface so routing sources can expose their target endpoints, and update AllSenders() to also check routing source endpoints when applying policies.
Member
|
@BlackChepo Thank you! |
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UseDurableOutboxOnAllSendingEndpoints()did not apply to RabbitMQ topic exchange endpoints created viaPublishMessagesToRabbitMqExchange<T>(), causing messages to be discarded when the broker is unreachable instead of being persisted in the outboxAllSenders()only iterates over subscriber endpoints, butPublishMessagesToRabbitMqExchangeregisters aTopicRouting<T>viaPublishWithMessageRoutingSource()— the underlying exchange endpoint was never visited by the policyFixes #2385