Fix DurableReceiver not completing listener after early dead-letter#2384
Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom Mar 31, 2026
Merged
Conversation
When an envelope arrived with a missing MessageType or failed metadata unwrapping, DurableReceiver moved it to the dead letter queue but never called CompleteAsync on the listener. For transports with manual offset management (e.g. Kafka with auto-commit disabled), this meant the offset was never advanced and the message was redelivered indefinitely on reconnect or pod restart. Fix by calling _completeBlock.PostAsync after _moveToErrors.PostAsync in both early-exit paths within ShouldPersistBeforeProcessing.
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an envelope arrived with a missing MessageType or failed metadata unwrapping, DurableReceiver moved it to the dead letter queue but never called CompleteAsync on the listener. For transports with manual offset management (e.g. Kafka with auto-commit disabled), this meant the offset was never advanced and the message was redelivered indefinitely on reconnect or pod restart.
Fix by calling _completeBlock.PostAsync after _moveToErrors.PostAsync in both early-exit paths within ShouldPersistBeforeProcessing.
Closes #2383