Fix FluentValidation not applying to AsParameters type with FromBody#2368
Merged
jeremydmiller merged 1 commit intomainfrom Mar 29, 2026
Merged
Fix FluentValidation not applying to AsParameters type with FromBody#2368jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
…present When [AsParameters] was used with a [FromBody] property, the AsParametersBindingFrame overwrote chain.RequestType to the body property type. The FluentValidation policy only checked RequestType, so validators on the AsParameters type itself were never applied. The fix tracks the AsParameters type separately on HttpChain and updates the FluentValidation policy to also add validation middleware for the AsParameters type when it differs from RequestType and has a registered validator. Fixes #2358 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2358
[AsParameters]is used with a[FromBody]property,AsParametersBindingFrameoverwriteschain.RequestTypeto the body property type. The FluentValidation policy only checkedRequestType, so validators on the[AsParameters]type itself were silently ignored.AsParametersTypeproperty toHttpChainthat tracks the original[AsParameters]type. TheHttpChainFluentValidationPolicynow checks for validators on both theRequestType(body type) and theAsParametersType, adding middleware for both when validators exist.Files changed
HttpChain.csAsParametersTypepropertyAsParametersBindingFrame.cschain.AsParametersTypeduring parameter bindingHttpChainFluentValidationPolicy.csaddValidationMiddlewarehelper; also validatesAsParametersTypewhen different fromRequestTypeFormEndpoints.cs[AsParameters]+[FromBody]+ validatorasparameters_binding.csvalidation.mdTest plan
post_body_services_and_route_argumentstest still passes (mentioned in issue as potential regression)🤖 Generated with Claude Code