Fix FromQuery(Name) with dots generating invalid C# variables#2354
Merged
jeremydmiller merged 1 commit intomainfrom Mar 25, 2026
Merged
Fix FromQuery(Name) with dots generating invalid C# variables#2354jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
…names When using [FromQuery(Name = "hub.mode")] on a parameter, the code generator used the dotted name as the C# variable name (e.g., var hub.mode), which fails to compile. Added dot sanitization to SanitizeFormNameForVariable so dotted query string names produce valid C# identifiers (e.g., hub_mode). Closes #2352 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[FromQuery(Name = "hub.mode")]is used, the code generator was using the dotted name as the C# variable name (e.g.,var hub.mode = ...), which fails to compile.) sanitization toSanitizeFormNameForVariableso dotted query string names produce valid C# identifiers (e.g.,hub_mode)4.0→4.0.3) since the4.0tag doesn't existTest plan
Bug_2352_fromquery_name_with_dotstest with dotted string and int query parameters🤖 Generated with Claude Code