Fix per-handler [Transactional] mode override ignored with Storage si…#2325
Merged
jeremydmiller merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
…de effects When SideEffectPolicy processes Storage return types (Insert<T>, Update<T>, etc.) at startup, it calls ApplyTransactionSupport before TransactionalAttribute.Modify has run. This caused the per-handler Mode override to be ignored, always falling back to the global DefaultMode. Added ResolveEffectiveMode() to EFCorePersistenceFrameProvider that checks handler method/type [Transactional] attributes directly via reflection when the chain tag isn't yet set. Added IsModeExplicitlySet property to TransactionalAttribute to support this check. Closes #2319 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 22, 2026
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…de effects
When SideEffectPolicy processes Storage return types (Insert, Update, etc.) at startup, it calls ApplyTransactionSupport before TransactionalAttribute.Modify has run. This caused the per-handler Mode override to be ignored, always falling back to the global DefaultMode.
Added ResolveEffectiveMode() to EFCorePersistenceFrameProvider that checks handler method/type [Transactional] attributes directly via reflection when the chain tag isn't yet set. Added IsModeExplicitlySet property to TransactionalAttribute to support this check.
Closes #2319