Fix [AlwaysPublishResponse] on remote request/reply#2301
Merged
jeremydmiller merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
…2299) The attribute only worked for in-process InvokeAsync<T> because that path sets Envelope.ResponseType (a CLR Type not serializable over the wire). Remote request/reply hits a different code path in EnqueueCascadingAsync that sends the reply but never checks if the response should also be published. Added an explicit AlwaysPublishResponse flag on Envelope that the attribute sets, and check it in the ReplyUri code path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2299
[AlwaysPublishResponse]was silently ignored when a handler processed a message via remote request/reply (e.g., TCP, RabbitMQ). The response was sent back to the caller'sReplyUribut never published as a cascading message.ReplyUricode path inEnqueueCascadingAsyncwhich always returned after sending the reply, never checking if the response should also be published. The in-process path worked because it setsEnvelope.ResponseType(a CLRTypenot serializable over the wire).AlwaysPublishResponseflag onEnvelopethat the attribute's generated code sets. TheReplyUricode path now checks this flag and also publishes the response when true.Test plan
always_publish_response_should_also_publish_on_remote_request_reply— verifies remoteInvokeAsync<T>with[AlwaysPublishResponse]both returns the response AND publishes itremote_invocationtests pass (no regressions)🤖 Generated with Claude Code