Add declarative Marten data requirements for handler middleware#2296
Merged
jeremydmiller merged 1 commit intomainfrom Apr 6, 2026
Merged
Add declarative Marten data requirements for handler middleware#2296jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
Member
Author
|
I hate the usability on this one. Not thinking this goes in anytime soon. |
Member
Author
NotesAs an easier to use alternative, let's keep the current syntax, but add attribute alternatives for declaring that a document must or must not exist first: [DocumentDoesNotExist<User>(nameof(AddUser.UserId))]
public void Handle(AddUser command)
{
}
// assume a property named "Id" or "UserId" on the command
[DocumentExists<User>]
public void Handle(PromoteUser command)
{
} |
2607c75 to
304a53b
Compare
…ocumentDoesNotExist] attributes
Introduces a data requirements system for Wolverine handlers and HTTP endpoints that
declaratively verify Marten document existence before execution. Includes:
- IMartenDataRequirement interface with batched query support
- DocumentExists<TDoc,TId> and DocumentDoesNotExist<TDoc,TId> runtime checks
- [DocumentExists<T>] and [DocumentDoesNotExist<T>] attributes for code generation
- MartenOps.Document<T>().MustExist()/MustNotExist() fluent API for Before methods
- Convention-based identity resolution ({TypeName}Id, Id, or explicit property name)
- Automatic batching of multiple requirements into a single Marten batch query
- Detach external Marten project references in favor of NuGet packages
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
304a53b to
777a161
Compare
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IMartenDataRequirementsupport inBefore/Validatemiddleware methods that throwRequiredDataMissingExceptionon failureMustNotExistwas creatingDocumentExistsinstead ofDocumentDoesNotExistRequirementResultContinuationPolicyto handle all Before method names (not just Validate/ValidateAsync)MartenDataRequirementFrameimplementingIBatchableFramefor efficient batch querying when combined with entity loadsMartenDataRequirementContinuationStrategydetectingIMartenDataRequirementandIEnumerable<IMartenDataRequirement>returns[Entity]attributeTest plan
IMartenDataRequirement(MustExist) happy + sad pathIEnumerable<IMartenDataRequirement>(MustExist + MustNotExist) happy + 2 sad paths[Entity]attribute happy + sad path (validates batching)🤖 Generated with Claude Code