Fix code gen missing non-saga handler with Separated mode#2290
Merged
jeremydmiller merged 1 commit intomainfrom Mar 12, 2026
Merged
Fix code gen missing non-saga handler with Separated mode#2290jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
…n Separated mode When a message type has both a Saga handler and a separate non-saga handler with MultipleHandlerBehavior.Separated, the non-saga handler was moved to ByEndpoint but never yielded as a code file because explodeAllFiles() used an if/else that only yielded ByEndpoint chains when the parent had no handlers. Closes #2289 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
explodeAllFiles()inHandlerGraph.GeneratesCode.csto always yieldByEndpointchains, not only when the parent chain has no handlersMultipleHandlerBehavior.Separated, the non-saga handler was moved toByEndpointbut its code file was never generated because theif/elselogic only yieldedByEndpointchains when the parent had zero handlersTest plan
using_a_saga_with_separated_behavior_mode)Closes #2289
🤖 Generated with Claude Code