Add EditAndReplayAsync to Oracle, compliance test, and fix EFCore test setup#2280
Merged
jeremydmiller merged 5 commits intomainfrom Mar 10, 2026
Merged
Add EditAndReplayAsync to Oracle, compliance test, and fix EFCore test setup#2280jeremydmiller merged 5 commits intomainfrom
jeremydmiller merged 5 commits intomainfrom
Conversation
… before replay Supports updating the serialized message body inside a dead letter envelope and marking it as replayable in a single operation. Implemented across all persistence providers (RDBMS, RavenDb, CosmosDb) with no-op stubs for NullMessageStore and MultiTenantedMessageStore. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
StopAsync only stops background services but does not dispose the DI container, so NpgsqlDataSource and other resources leak their connection pools. This fixes 58 test files across all test projects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… test schema setup Implement the missing IDeadLetters.EditAndReplayAsync method on the Oracle message store and add a centralized compliance test in MessageStoreCompliance so all persistence providers are covered. Fix EFCoreTests failures by dropping the mt_items schema before host startup, ensuring Weasel migrations can cleanly create/alter columns without conflicting with stale data from previous test runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unregister the listener and set status before calling TrySetException, so that with RunContinuationsAsynchronously the listener is cleaned up before any awaiter continuation resumes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WebApplication implements IAsyncDisposable, not IDisposable in .NET 9. Use DisposeAsync() instead of Dispose() to fix compilation errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditAndReplayAsyncto OracleIMessageStore.DeadLetters— implements the missing interface method that updates the body of a dead letter envelope and marks it as replayable in a single operationcan_edit_and_replay_dead_letter_envelopetest — moved from Oracle-specific tests intoMessageStoreComplianceso all 13 persistence providers (PostgreSQL, SQL Server, Oracle, SQLite, MySQL, RavenDb, CosmosDb + variants) are coveredEFCorePersistenceContextandBug_252_codegen_issuenow drop themt_itemsschema before host startup so Weasel migrations can cleanly apply NOT NULL constraints without conflicting with stale data from previous test runsTest plan
MessageStoreComplianceimplementations passcan_edit_and_replay_dead_letter_envelopeBug_1846timing test, passes in isolation)EditAndReplayAsyncverified: reads dead letter, replaces body, re-serializes, updates body + replayable flag🤖 Generated with Claude Code