Merged
Conversation
Member
|
@dmytro-pryvedeniuk Thank you for doing that! |
This was referenced Mar 9, 2026
This was referenced Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two flaky tests fixed, simplified and hardened.
message_with_retry_policy_saves_to_redis_and_retriesuses hard-coded delays which sometimes are not enough. Also, instead of strict asserts it relies on if conditions with logging instead of assertion. E.g. it's assumed that the default EndpointMode is Durable while it's not anymore and instead of asserting the test just logs that it can be the problem. So when the test sometimes passes it's actually just due to such relaxed validation.rate_limited_messages_are_delayed_with_native_schedulingwaits 15 seconds for 2 messages handled and then throws an exception. I have to enable DurableInbox (sometimes one message does not arrive) and make the test ready for the messages arriving in different order (see output below).For both tests instead of one hard-coded delay more granular delays are used with the log output.
Message B arrives first: