Fix [FromQuery] array binding ignoring Name alias#2262
Merged
jeremydmiller merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
…or parameters The query string key for arrays, collections, and nullable types was using the C# parameter name instead of the [FromQuery(Name = "...")] alias in HttpChain.TryFindOrCreateQuerystringValue, causing a discrepancy with [AsParameters] which handled aliases correctly. Closes #2257 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[FromQuery(Name = "v")] string[] Valuesand was bound via[FromQuery], the generated code read fromhttpContext.Request.Query["Values"]instead ofhttpContext.Request.Query["v"]. The[AsParameters]path handled this correctly.HttpChain.TryFindOrCreateQuerystringValue(Type, string, string?)passedparameterName(C# name) instead ofkey(the alias) when constructingParsedArrayQueryStringValue,ParsedCollectionQueryStringValue, and nullable type frames.[FromQuery]and[AsParameters]on records and settable properties.Closes #2257
Test plan
[FromQuery]on records[FromQuery]and[AsParameters]for aliased arrays🤖 Generated with Claude Code