Fix Kafka durable mode offset management by removing EnableAutoOffset…#2256
Merged
jeremydmiller merged 1 commit intomainfrom Mar 2, 2026
Merged
Fix Kafka durable mode offset management by removing EnableAutoOffset…#2256jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
…Store override Remove EnableAutoOffsetStore = false so offsets are auto-stored on each Consume() call, while keeping EnableAutoCommit = false so offsets are only committed when Wolverine explicitly calls Commit() in CompleteAsync(). This gives correct at-least-once semantics without needing to thread ConsumeResult through to CompleteAsync. Previously, offsets never advanced because StoreOffset() was never called, causing message loss on consumer restart. Also fix propagate_group_id_to_partition_key test by adding the missing publish route for TriggerFromGroupId and setting AutoOffsetReset.Earliest to avoid consumer group join timing races. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Store override
Remove EnableAutoOffsetStore = false so offsets are auto-stored on each Consume() call, while keeping EnableAutoCommit = false so offsets are only committed when Wolverine explicitly calls Commit() in CompleteAsync(). This gives correct at-least-once semantics without needing to thread ConsumeResult through to CompleteAsync. Previously, offsets never advanced because StoreOffset() was never called, causing message loss on consumer restart.
Also fix propagate_group_id_to_partition_key test by adding the missing publish route for TriggerFromGroupId and setting AutoOffsetReset.Earliest to avoid consumer group join timing races.