Fix FromForm Name attribute not respecting hyphens #2140
Merged
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Closes GH-2064 The string and string[] branches in TryFindOrCreateFormValue() were not restoring variable.Name after ReadHttpFrame sanitized hyphens to underscores, causing [FromForm(Name="form-custom-kebab")] to look up "form_custom_kebab". Co-Authored-By: Claude Opus 4.6 <[email protected]>
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[FromForm(Name="form-custom-kebab")]generating code that looks upform_custom_kebabinstead ofform-custom-kebabvariable.Name = keyin thestringandstring[]branches ofTryFindOrCreateFormValue()to match the pattern used by all other branches and byTryFindOrCreateQuerystringValue()Test plan
from_form_respects_custom_kebab_namepassesfrom_form_bindingtests pass (11 passed, 2 skipped)using_form_parameterstests pass (28 passed, 8 skipped)Closes #2064
🤖 Generated with Claude Code