Fix SNS batch publish missing message attributes and misplaced Request allocation #2137
+116
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t allocation OutgoingSnsBatch never called ISnsEnvelopeMapper.ToAttributes() when building PublishBatchRequestEntry objects, so message attributes (including ProtocolVersion and any custom attributes) were silently dropped for all batched SNS publishes. Only the inline sending path in AmazonSnsTopic.SendMessageAsync() called ToAttributes(). Also moved the PublishBatchRequest assignment out of the foreach loop where it was needlessly recreated on every iteration. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Member
|
@desty2k Thank you! The aws CI thing is, um, not ready for prime time. I'll be running this locally before any nuget release just in case |
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ISnsEnvelopeMapper.ToAttributes()for each entry inOutgoingSnsBatch, matching the single-message path inAmazonSnsTopic.SendMessageAsync()PublishBatchRequestconstruction outside the per-envelope try/catch so a single mapping failure doesn't leaveRequestuninitializedTests
OutgoingSnsBatch:Requestis always constructed even when all envelopes fail mapping