Skip to content

Conversation

@Joelgullander
Copy link
Contributor

Need input here, am I on the right track? @jeremydmiller

This introduces configurable rate limiting with middleware and continuation handling, plus documentation and core tests to validate scheduling and enforcement.
@jeremydmiller
Copy link
Member

@Joelgullander Hey, I think this looks solid. The exception handling policy looks right to me too.

The only ask I have is could you lift a base "compliance tests" class for the IRateLimitStore and stick that in Wolverine.ComplianceTests? That'll help us move on to other DBs

Introduce a reusable IRateLimitStore compliance suite and refactor the SQL Server rate limit tests to use it while retaining the schema creation check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants