Add support for SignalR hubs requiring authorization#2103
Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom Feb 4, 2026
Merged
Add support for SignalR hubs requiring authorization#2103jeremydmiller merged 1 commit intoJasperFx:mainfrom
jeremydmiller merged 1 commit intoJasperFx:mainfrom
Conversation
Member
|
@PerfectlyNormal One thing at a time. Let's go w/ what you've done and just collect feedback from users. |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really happy with the error handling in
SignalRClientEndpoint.BuildListenerAsync. Since we try connecting immediately any errors prevents us from starting. The most common error will (probably) be unauthorized, so catching and logging that. But there's probably a lot better ways of handling this.SignalR expects a
Func<Task<string?>>as a token provider. I wrapped that so we get access to theIServiceProviderto get configuration or anything like that. That turns into aFunc<IServiceProvider, Func<Task<string?>>>which isn't very pretty.Feel free to edit or suggest improvements