Skip to content

Setting keep_until correctly in EF Core transaction middleware when n… #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Dec 2, 2025
Merged

Setting keep_until correctly in EF Core transaction middleware when n… #1888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Persistence/EfCoreTests/end_to_end_efcore_persistence.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ public async Task ef_core_middleware_is_marking_the_envelope_as_handled()
var persisted = fromStore.Single(x => x.Id == envelope.Id);
persisted.Status.ShouldBe(EnvelopeStatus.Handled);

persisted.KeepUntil.HasValue.ShouldBeTrue();
}

private async Task<Item> loadItem(Guid id)
Expand Down
9 changes: 6 additions & 3 deletions src/Persistence/Wolverine.EntityFrameworkCore/Internals/EfCoreEnvelopeTransaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,13 @@ public async ValueTask CommitAsync(CancellationToken cancellation)

// Are we marking an existing envelope as persisted?
if (_messaging.Envelope.WasPersistedInInbox)
{
{
var keepUntil =
DateTimeOffset.UtcNow.Add(_messaging.Runtime.Options.Durability.KeepAfterMessageHandling);
var cmd = conn.CreateCommand(
$"update {_database.SchemaName}.{DatabaseConstants.IncomingTable} set {DatabaseConstants.Status} = '{EnvelopeStatus.Handled}' where id = @id")
.With("id", _messaging.Envelope.Id);
$"update {_database.SchemaName}.{DatabaseConstants.IncomingTable} set {DatabaseConstants.Status} = '{EnvelopeStatus.Handled}', {DatabaseConstants.KeepUntil} = @keep where id = @id")
.With("id", _messaging.Envelope.Id)
.With("keep", keepUntil);
cmd.Transaction = tx;
await cmd.ExecuteNonQueryAsync(cancellation);
}
Expand Down
Loading