Skip to content

Dealing w/ the extension loading being annoying when it hits native a… #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 2 commits into from
Nov 13, 2025
Merged

Dealing w/ the extension loading being annoying when it hits native a… #1839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c10c9ab
Dealing w/ the extension loading being annoying when it hits native a…
jeremydmiller Nov 13, 2025
273d311
hopefully getting over the EF Core diamond dep problems
jeremydmiller Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Persistence/PersistenceTests/PersistenceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<IsPackable>false</IsPackable>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down Expand Up @@ -39,6 +40,11 @@
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.0"/>
</ItemGroup>

<ItemGroup Condition="'$(targetframework)' == 'net10.0'">
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="10.0.0-rc.2"/>
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="10.0.0"/>
</ItemGroup>

<ItemGroup>
<Content Include="$(SolutionDir)xunit.runner.json" CopyToOutputDirectory="PreserveNewest"/>
</ItemGroup>
Expand Down
32 changes: 31 additions & 1 deletion src/Wolverine/ExtensionLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,25 @@ namespace Wolverine;
internal static class ExtensionLoader
{
private static Assembly[]? _extensions;
private static bool hasWarned = false;

internal static bool IsModule(Assembly assembly)
{
try
{
if (assembly.HasAttribute<WolverineModuleAttribute>()) return true;
}
catch (Exception)
{
if (!hasWarned)
{
Console.WriteLine("To disable automatic Wolverine extension finding, and stop these messages, see:");
Console.WriteLine("https://wolverinefx.net/guide/extensions.html#disabling-assembly-scanning");
}
}

return false;
}

internal static Assembly[] FindExtensionAssemblies()
{
Expand All @@ -17,8 +36,19 @@ internal static Assembly[] FindExtensionAssemblies()
return _extensions;
}

Action<string> logFailure = msg =>
{
if (!hasWarned)
{
Console.WriteLine("To disable automatic Wolverine extension finding, and stop these messages, see:");
Console.WriteLine("https://wolverinefx.net/guide/extensions.html#disabling-assembly-scanning");
}

Console.WriteLine(msg);
};

_extensions = AssemblyFinder
.FindAssemblies(msg => Console.WriteLine(msg), a => a.HasAttribute<WolverineModuleAttribute>(), false)
.FindAssemblies(logFailure, a => a.HasAttribute<WolverineModuleAttribute>(), false)
.Concat(AppDomain.CurrentDomain.GetAssemblies())
.Distinct()
.Where(a => a.HasAttribute<WolverineModuleAttribute>())
Expand Down
Loading