Skip to content

Smarter assertions on requested reply mechanics to avoid unnecessary failure acks #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Sep 17, 2025
Merged

Smarter assertions on requested reply mechanics to avoid unnecessary failure acks #1704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<NoWarn>1570;1571;1572;1573;1574;1587;1591;1701;1702;1711;1735;0618</NoWarn>
<ImplicitUsings>true</ImplicitUsings>
<Nullable>enable</Nullable>
<Version>4.12.0</Version>
<Version>4.12.1</Version>
<RepositoryUrl>$(PackageProjectUrl)</RepositoryUrl>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
Expand Down
8 changes: 6 additions & 2 deletions src/Wolverine/Runtime/MessageContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ private bool hasRequestedReply()

private bool isMissingRequestedReply()
{
return Outstanding.All(x => x.MessageType != Envelope!.ReplyRequested);
return Outstanding.Concat(_sent ?? []).All(x => x.MessageType != Envelope!.ReplyRequested);
}

public async Task FlushOutgoingMessagesAsync()
Expand Down Expand Up @@ -95,11 +95,15 @@ public async Task FlushOutgoingMessagesAsync()
await flushScheduledMessagesAsync();
}

_sent ??= new();
_sent.AddRange(_outstanding);
_outstanding.Clear();

_hasFlushed = true;
}

private List<Envelope>? _sent;

public async Task AssertAnyRequiredResponseWasGenerated()
{
if (hasRequestedReply() && _channel is not InvocationCallback && isMissingRequestedReply())
Expand All @@ -108,7 +112,7 @@ public async Task AssertAnyRequiredResponseWasGenerated()
if (_outstanding.Any())
{
failureDescription += "Actual cascading messages were " +
_outstanding.Select(x => x.MessageType).Join(", ");
_outstanding.Concat(_sent ?? []).Select(x => x.MessageType).Join(", ");
}
else
{
Expand Down