Disabling automatic failure acks by default. Finally. Closes GH-1578

src/Testing/CoreTests/Acceptance/remote_invocation.cs

@@ -35,13 +35,17 @@ public async Task InitializeAsync()
             {
                 opts.ServiceName = "Receiver1";
                 opts.ListenAtPort(_receiver1Port);
+
+                opts.EnableAutomaticFailureAcks = true;
             }).StartAsync();
 
         _receiver2 = await Host.CreateDefaultBuilder()
             .UseWolverine(opts =>
             {
                 opts.ServiceName = "Receiver2";
                 opts.ListenAtPort(_receiver2Port);
+
+                opts.EnableAutomaticFailureAcks = true;
             }).StartAsync();
 
         _sender = await Host.CreateDefaultBuilder()
@@ -57,6 +61,8 @@ public async Task InitializeAsync()
 
                 opts.PublishMessage<Request4>().ToPort(_receiver1Port);
                 opts.PublishMessage<Request4>().ToPort(_receiver2Port);
+
+                opts.EnableAutomaticFailureAcks = true;
             }).StartAsync();
     }
 

src/Testing/CoreTests/Runtime/MoveToErrorQueueTester.cs

@@ -23,6 +23,8 @@ public MoveToErrorQueueTester()
     [Fact]
     public async Task should_send_a_failure_ack_if_not_local()
     {
+        theRuntime.Options.EnableAutomaticFailureAcks = true;
+
         theEnvelope.Destination = new Uri("tcp://localhost:9000");
 
         await theContinuation.ExecuteAsync(theLifecycle, theRuntime, DateTimeOffset.Now, null);

src/Testing/CoreTests/WolverineOptionsTests.cs

@@ -26,9 +26,9 @@ public void publish_agent_events_should_be_false_by_default()
     }
 
     [Fact]
-    public void failure_acks_are_enabled_by_default()
+    public void failure_acks_are_NOT_enabled_by_default()
     {
-        new WolverineOptions().EnableAutomaticFailureAcks.ShouldBeTrue();
+        new WolverineOptions().EnableAutomaticFailureAcks.ShouldBeFalse();
     }
 
     [Fact]

src/Wolverine/WolverineOptions.cs

@@ -191,9 +191,9 @@ public AutoCreate AutoBuildMessageStorageOnStartup
 
     /// <summary>
     /// Should message failures automatically try to send a failure acknowledgement message back to the
-    /// original caller. Default is true.
+    /// original caller. Default is *false* as of Wolverine 4.6
     /// </summary>
-    public bool EnableAutomaticFailureAcks { get; set; } = true;
+    public bool EnableAutomaticFailureAcks { get; set; } = false;
 
     private void deriveServiceName()
     {