Skip to content

Improved handling of latched senders in QuickSendAsync #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Jun 27, 2025
Merged

Improved handling of latched senders in QuickSendAsync #1515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/Wolverine/Envelope.Internals.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,24 @@ internal async ValueTask QuickSendAsync()

_enqueued = true;

if (Sender.Latched) return;
if (Sender.Latched)
{
// If the sender is latched, it indicates that the endpoint is currently unavailable
// (e.g., due to a network disconnection or a failure in the transport).
// In such cases, we should *not* attempt to send the message immediately.
//
// Instead, if the sender is a SendingAgent, we explicitly mark the envelope as failed
// so that it will be retried later when the connection is re-established.
//
// This conditional block ensures that latched agents skip enqueuing the message,
// but still track the failure to maintain durability and retry logic.
if (Sender is SendingAgent sendingAgent)
{
await sendingAgent.MarkProcessingFailureAsync(this, null);
}

return;
}

if (Sender.Endpoint?.TelemetryEnabled ?? false)
{
Expand Down
Loading