Skip to content

fix: api description contain invalid request type for GET requests #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Jun 27, 2025
Merged

fix: api description contain invalid request type for GET requests #1507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/Http/Wolverine.Http.Tests/swashbuckle_integration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,21 @@ public void apply_tags_from_tags_attribute()
var (item, op) = FindOpenApiDocument(OperationType.Post, "/users/sign-up");
op.Tags.ShouldContain(x => x.Name == "Users");
}

[Fact]
public async Task request_body_not_required_with_primitive_query_string()
{
var endpoint = EndpointFor("/querystring/datetime");

var (item, op) = FindOpenApiDocument(OperationType.Get, "/querystring/datetime");
op.RequestBody.ShouldBeNull();
}

[Fact]
public async Task request_body_not_required_with_complex_query_string()
{
var endpoint = EndpointFor("/api/bigquery");
var (_, op) = FindOpenApiDocument(OperationType.Get, "/api/bigquery");
op.RequestBody.ShouldBeNull();
}
}
2 changes: 1 addition & 1 deletion src/Http/Wolverine.Http/HttpChain.ApiDescription.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ private void fillResponseTypes(ApiDescription apiDescription)

private void fillRequestType(ApiDescription apiDescription)
{
if (HasRequestType && !IsFormData)
if (HasRequestType && !IsFormData && apiDescription.HttpMethod != "GET")
{
var parameterDescription = new ApiParameterDescription
{
Expand Down
Loading