Skip to content

Hardening SNS protocol against the new null collection behavior. Clos… #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Jun 17, 2025
Merged

Hardening SNS protocol against the new null collection behavior. Clos… #1504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Transports/AWS/Wolverine.AmazonSns/Internal/SnsSenderProtocol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ public OutgoingSnsBatch(AmazonSnsTopic topic, ILogger logger, IEnumerable<Envelo
public async Task ProcessSuccessAsync(ISenderCallback callback, PublishBatchResponse response,
OutgoingMessageBatch batch)
{
if (!response.Failed.Any())
if (response.Failed == null || !response.Failed.Any())
{
await callback.MarkSuccessfulAsync(batch);
}
else
{
var fails = new List<Envelope>();
foreach (var fail in response.Failed)
foreach (var fail in response.Failed ?? [])
{
if (_envelopes.TryGetValue(fail.Id, out var env))
{
Expand All @@ -106,7 +106,7 @@ public async Task ProcessSuccessAsync(ISenderCallback callback, PublishBatchResp
}

var successes = new List<Envelope>();
foreach (var success in response.Successful)
foreach (var success in response.Successful ?? [])
{
if (_envelopes.TryGetValue(success.Id, out var env))
{
Expand Down
Loading