Fix dependency lifetime issue in PingPong sample projects#1445
Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom May 27, 2025
Merged
Fix dependency lifetime issue in PingPong sample projects#1445jeremydmiller merged 1 commit intoJasperFx:mainfrom
jeremydmiller merged 1 commit intoJasperFx:mainfrom
Conversation
Member
|
@hamedsabzian Good catch. That wasn't an issue when we depended on Lamar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
IMessageBusis registered with the scoped lifetime. But it is used in the background services as a constructor parameter. Only the singleton dependencies can be injected directly into the background services.options.ApplicationAssemblyis required. Without it, the message handlers are not found in the consumer applications.