Skip to content

dont use linq in SqlSenderProtocol - #119

Merged
jeremydmiller merged 1 commit into
JasperFx:mainfrom
SimonCropp:dont-use-linq-in-SqlSenderProtocol
Dec 22, 2022
Merged

dont use linq in SqlSenderProtocol#119
jeremydmiller merged 1 commit into
JasperFx:mainfrom
SimonCropp:dont-use-linq-in-SqlSenderProtocol

Conversation

@SimonCropp

Copy link
Copy Markdown
Contributor
  • avoids two warnings about nullability
  • faster and less alloc

@jeremydmiller
jeremydmiller merged commit 7f3eda9 into JasperFx:main Dec 22, 2022
erdtsieck pushed a commit to erdtsieck/wolverine that referenced this pull request Aug 25, 2026
…-test in CI

Bobcat.Supervisor 0.6.1 was cut on 2026-07-31, before ISupervisorObserver
(JasperFx/bobcat#96) and the tap on MTP's testing/testUpdates/tests
(JasperFx/bobcat#99, JasperFx#119) landed, so a supervised run could only be observed
after it finished. That is precisely the wrong time: the supervisor reports
per-test results when a batch FINISHES, and a batch that wedges never finishes,
so it reports nothing at all. On JasperFx#4083 a CIMarten job's last line was
"275 test(s): 275 batched, 0 isolated", printed 18m33s before the 20 minute cap
cancelled it, and the log could not name the test that hung.

Bobcat 0.7.0 is cut from that work; this moves the pin onto it and adds an
observer that prints one line per test as a worker picks it up. So a wedged job
now ends with the name of the test it wedged on as its last line of output,
which is the bookmark that says where to look -- the stall watchdog's dumpasync
capture (build/ci-memory-sampler.sh, JasperFx#4084) remains the actual evidence.

In-progress updates only. The terminal update carries the same verdict the
end-of-run summary already prints, and doubling every line would bury the one
line that matters, which is the last one. The lane number is on each line
because Bobcat fires these from the worker client's I/O thread, so lines from
different lanes interleave.

Gated on GITHUB_ACTIONS, the same check RetryLedger already uses: locally a run
reaches its summary, and `dotnet run -- --output Detailed` is the per-test view.

Verified against the published package -- build/obj/project.assets.json resolves
Bobcat.Supervisor/0.7.0 and build.csproj compiles clean.

Refs JasperFx#4083.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants