Fix inconsistent tenant/activity test #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test relied on accessing IHttpActivityFeature after the request completed in order to extract the Activity to assert against. However, the runtime (https://github.com/dotnet/aspnetcore/blob/main/src/Hosting/Hosting/src/Internal/HostingApplication.cs) actually sets the value of IHttpActivityFeature.Activity to null after each request so that the IHttpActivityFeature can be recycled. This commit works around this behavior by copying the Activity into a custom feature.
richardszalay
force-pushed
the
fix_tenant_activity_test
branch
from
cc4ab7d to
a3bb54e
Compare
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test relied on accessing IHttpActivityFeature after the request completed in order to extract the Activity to assert against.
However, the runtime (HostingApplication) actually sets the value of HttpActivityFeature.Activity to null after each request so that the HttpActivityFeature can be recycled.
This commit works around this behavior by copying the Activity into a custom feature.