Weasel 8.14.1: upgrade to JasperFx 1.26 + fix Spectre.Console 0.55 API break#252
Merged
jeremydmiller merged 1 commit intomasterfrom Apr 21, 2026
Merged
Conversation
…I break Upgrades the Weasel graph onto the latest JasperFx (1.24.0 → 1.26.0), which transitively upgrades Spectre.Console from 0.53 to 0.55. Spectre.Console 0.55 removed the StringExtensions.EscapeMarkup(string) extension (the static Spectre.Console.Markup.Escape(string) is the replacement). Weasel.Core.CommandLine.AssertCommand used the old extension form in two places, which surfaced downstream in Marten as a MissingMethodException on every db-assert / resources command. Patched AssertCommand to call Markup.Escape directly. Unblocks JasperFx/marten#4269. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jeremydmiller
added a commit
to JasperFx/marten
that referenced
this pull request
Apr 21, 2026
CoreTests.jasper_fx_mechanics.* were failing on PR CI with:
System.MissingMethodException: Method not found:
'System.String Spectre.Console.StringExtensions.EscapeMarkup(System.String)'
at Weasel.Core.CommandLine.AssertCommand.Execute(WeaselInput input)
Root cause: Spectre.Console 0.55 (pulled in transitively by the
JasperFx 1.26 bump earlier on this branch) removed the
StringExtensions.EscapeMarkup(string) extension. The replacement
Spectre.Console.Markup.Escape(string) is the supported API. Weasel
8.14.1 switches to it; see JasperFx/weasel#252.
Local CoreTests.jasper_fx_mechanics subset: 13/13 pass (was 6/13).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the Weasel dependency graph onto the latest JasperFx (1.24.0 → 1.26.0), which transitively pulls Spectre.Console 0.53 → 0.55 for every downstream consumer. Patches the one spot in Weasel that called a Spectre API that 0.55 removed.
The bug
Spectre.Console 0.55 removed the
StringExtensions.EscapeMarkup(string)extension method — the staticSpectre.Console.Markup.Escape(string)is the replacement.Weasel.Core.CommandLine.AssertCommandused the old extension form in two places:Downstream in Marten this surfaced as:
…on every
db-assert/resourcescommand that went through this code path (7 failing tests inCoreTests.jasper_fx_mechanics.*on marten#4269).The fix
Directory.Packages.props:JasperFx1.24.0 → 1.26.0 (transitively moves Spectre.Console to 0.55)src/Weasel.Core/CommandLine/AssertCommand.cs:database.Identifier.EscapeMarkup()→Markup.Escape(database.Identifier)Directory.Build.props: Version 8.14.0 → 8.14.1Test plan
dotnet build Weasel.sln— 0 errors (357 pre-existing warnings)Downstream
Unblocks JasperFx/marten#4269, which needs a JasperFx 1.26.0 floor for its
JasperFx.Events1.29.0 uptake. Once Weasel 8.14.1 ships I'll bump Marten to consume it and drop the standalone Spectre.Console pin in Marten'sDirectory.Packages.props.🤖 Generated with Claude Code