Quote reserved keywords in PostgreSQL function update fragments#242
Merged
jeremydmiller merged 2 commits intoJasperFx:masterfrom Apr 8, 2026
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Problem
PostgreSQL reserved keywords (such as
offset,limit,all, andselect) cause aPostgresException (42601): syntax errorwhen used as column names in generated PL/pgSQL functions. This happens because the SQL generator inTableColumnwas using the rawNameproperty instead of a delimited identifier in theSETclause of update statements.Example of failing SQL:
ON CONFLICT (id) DO UPDATE SET offset = EXCLUDED.offset; -- Syntax error near 'offset'The Fix
Updated
TableColumn.ToFunctionUpdate()to use theQuotedNameproperty. This ensures that column assignments inside internal functions are always safely wrapped in double quotes (e.g.,"offset" = p_offset).Changes
Weasel.Postgresql.Tables.TableColumn.ToFunctionUpdate()to use quoted identifiers.Theorytestto_function_update_should_quote_reserved_keywordsinTableColumnTests.csto verify string generation for common keywords.Theoryindetecting_table_deltas.csthat iterates through 70+ PostgreSQL reserved keywords to ensure they work across the full DDL lifecycle without triggering "infinite migrations" (false deltas).Verification
detecting_table_deltas.no_deltaremains green, ensuring no regression in schema comparison logic.Related Marten PR: JasperFx/marten#4237