Fix TPH topological sort when base class has FK dependency#229
Merged
Conversation
When a TPH base class has a foreign key, derived types inherit the same FK, causing duplicate dependency edges in the topological sort. This inflates in-degree counts in Kahn's algorithm but only decrements once, triggering false cycle detection and returning unsorted results. Fix: use HashSet instead of List for dependency edges to deduplicate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HashSet<IEntityType>instead ofList<IEntityType>for dependency edges to deduplicateTest plan
entity_types_sorted_correctly_when_base_class_has_fktest that reproduces the issue (fails without fix, passes with fix)can_apply_migration_when_base_class_has_fkintegration test🤖 Generated with Claude Code