Fix DI scope disposal and support for overridding the default command #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or command creation refactor(HostedCommandExtensions): simplify Oakton registration and command execution feat(HostedCommandExtensions): add OaktonOptions for configuration refactor(HostedCommandExtensions): remove HostedCommandOptions in favor of OaktonOptions test(HostedCommandsTester): update tests to use OaktonOptions and default command
|
@jeremydmiller This should address your concerns with the scope disposal mentioned in #93 (comment) Also added the ability to override the default command during the configuration stage, based on a discord conversation |
|
@tgardner I got this one in, but one more really important thing (I took care of it), you needed to ensure that the IHost was disposed too so that it isn't hanging on to locks or resources or who knows what. Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(DependencyInjectionCommandCreator): use ActivatorUtilities for command creation
refactor(HostedCommandExtensions): simplify Oakton registration and command execution
feat(HostedCommandExtensions): add OaktonOptions for configuration
refactor(HostedCommandExtensions): remove HostedCommandOptions in favor of OaktonOptions
test(HostedCommandsTester): update tests to use OaktonOptions and default command