Repository navigation
Add opts.Events.AutoDiscoverTagTypes to turn off DCB tag type discovery - #5806
Merged
Merged
Conversation
A store with strong-typed identifiers but no DCB still got a tag table per identifier, with its foreign key and indexes and a parameter on mt_quick_append_events. On by default so nothing changes for anyone else, and explicit RegisterTagType calls work either way. Closes #5798. Co-Authored-By: Germán Schuager <139658+gschuager@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5798. Thanks to @gschuager for the report and the design, credited as co-author.
An aggregate projection with a strong-typed identifier auto-registers that type as a DCB tag type. A store that doesn't use DCB still gets a table per identifier, with its foreign key and indexes and a parameter on
mt_quick_append_events. The reporter hit ten empty tables moving from 8.38.1 to 9.50.3.RegisterTagType<T>()calls keep working with it off.IEventStoreOptionsandEventGraph, with no existing signature changed.EventGraphis the only implementation in this repository.Turning it off on an existing database does not drop tag tables already there. The docs say so.
Verified: with the guard removed,
nothing_is_registered_or_built_when_auto_discovery_is_turned_offfindsmt_event_tag_ticket_idininformation_schema, read from the catalog rather than from configuration. With the guard in place, all 10 tests that ran in the class pass (2 of the 12 were skipped).🤖 Generated with Claude Code