Repository navigation
Match tabs and line breaks in string.IsNullOrWhiteSpace() queries - #5760
Merged
jeremydmiller merged 1 commit intoOct 26, 2026
Merged
jeremydmiller merged 1 commit into
jeremydmiller merged 1 commit into
Conversation
PostgreSQL trim() strips only spaces, so a member holding only tabs or line breaks was not treated as null or white space. Match the value against ^\s*$ instead.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5759
Problem
string.IsNullOrWhiteSpace(x.Member)in a LINQWhere()is translated totrim(member) = ''. PostgreSQLtrim()removes only spaces, so a member that holds only tabs or line breaks (for example"\t"or"\r\n") is not matched, and!string.IsNullOrWhiteSpace(...)returns it.Change
StringIsNullOrWhiteSpacenow emitsmember ~ '^\s*$'.\smatches spaces, tabs, line breaks, form feeds and vertical tabs.LinqTests.Bugs.is_null_or_white_space_matches_all_whitespacecovers"\t","\r\n"," \n "and"\f\v", for both the positive and the negated query.Testing
master(4 of 4) and passes with the change (4 of 4).LinqTestson net10.0: 1647 passed, 0 failed.