Testcase for GH-554 - #555
Closed
lngr wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 22, 2026
jeremydmiller
added a commit
that referenced
this pull request
Jul 22, 2026
…tdown drain (#5024) (#5025) Bumps JasperFx.Events 2.33.1 -> 2.34.0 to consume #555 (the two remaining tenant-scoped explorer read paths) and #557 (the extended-progression shutdown-drain fix), then implements/proves both from Marten's side. #5021 — the second pair of explorer reads #503 left untenanted: - Override IEventStore.QueryByTagsAsync(tags, tenantId, ct) in DocumentStore.EventStoreExplorer.cs with the same two-model scoping PR #5020 established for the stream reads: a conjoined single-database store bounds the outer mt_events scan with an e.tenant_id predicate on the AllowAnyTenant explorer session (the tag sub-selects match by the globally-unique seq_id, so the outer predicate discards cross-tenant seq_ids); a database-per-tenant / sharded store opens the session against the tenant's own database. Null delegates to the tenant-less overload, byte-identical to today. - Honour EventQuery.TenantId in QueryEventStore.QueryEventsAsync: a set tenant scopes the query with TenantIsOneOf (overriding the session's own filter); a null tenant is left untouched so the pre-existing per-tenant paging contract is unchanged. - Explorer tests: same tag / same event under two tenants on a conjoined store reads each tenant's slice in isolation. #5024 Phase 3 — consume + prove the #557 shutdown fix: - Bug_5024_extended_progression_survives_shutdown drives the real live-then-stopped daemon path (#5023 deliberately stopped doing this to de-flake #5008): start a live daemon, catch it up, StopAllAsync(), then issue an explicit WriteExtendedProgression and assert the row is NOT clobbered by a late "Stopped" heartbeat (Symptom 1) and no ObjectDisposedException reached the log on shutdown (Symptom 2). Deterministic because the upstream drain is now awaited; green across repeated runs. Claude-Session: https://claude.ai/code/session_01JQ9NHbg31EWJmrQK9EN6i8 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testcase for the query failures described in #554