SELECT access no longer required on database tables. - #537
Merged
Conversation
kiriwalawren
changed the title
This was referenced Jul 20, 2026
This was referenced Aug 4, 2026
Closed
jeremydmiller
added a commit
that referenced
this pull request
Aug 4, 2026
… status (#5180) Both overloads hardcoded `LastHeartbeat` and `AgentStatus` to null and never selected the columns, on the rationale that Marten modelled them but no daemon path wrote them (#519). That stopped being true at #537 — `ExtendedProgressionWriter` populates both on every flush, and `AllProjectionProgress` reads them back correctly. So the targeted per-cell read that #435 added *specifically* as the monitoring alternative to scanning every row returned NULL for exactly the two fields a monitor calls it for, with nothing to distinguish a placeholder from a fact — while the expensive path it was meant to replace returned the truth. Both queries now select `agent_status` and `heartbeat` when `EnableExtendedProgressionTracking` is on and hydrate them into the record. With extended tracking off the columns are not on the table, so the narrow column list is kept and both fields stay null. In the version-collapsing overload the telemetry follows the winning row rather than whichever candidate was read first. Claude-Session: https://claude.ai/code/session_017CTtw2kVRSZKp1p5RTxgAy Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
information_schema.tablesrequires that any accessor has SELECT permissions to view its contents.pg_stat_user_tablesdoes not. This problem surfaced when attempting to remove SELECT permissions from themt_hilotable.