Fix #4686 — implement IEventStoreInstrumentation on EventGraph#4690
Merged
Conversation
Companion to JasperFx 2.9.0 / #424, which introduced IEventStoreInstrumentation as a storage-agnostic surface for CritterWatch's monitoring toggles (starting with ExtendedProgressionEnabled). Marten's EventGraph already had the equivalent EnableExtendedProgressionTracking toggle, but only as a Marten-specific concrete property. EventGraph now implements IEventStoreInstrumentation. Both names refer to the same underlying field: * EnableExtendedProgressionTracking { get => ExtendedProgressionEnabled; set => ... } * ExtendedProgressionEnabled { get; set; } — the IEventStoreInstrumentation surface Existing callers that set EnableExtendedProgressionTracking continue to work unchanged — no [Obsolete] warning, just an alias. New code (including Wolverine.CritterWatch.Marten via IConfigureMarten) is encouraged to use the interface property so it can compile against JasperFx.Events without referencing Marten's concrete EventGraph. No schema changes — the six progression columns (heartbeat, agent_status, pause_reason, running_on_node, warning_behind_threshold, critical_behind_threshold) already exist in mt_event_progression and the daemon already writes them. Only the API surface changes. Five unit tests in CoreTests.Events.EventGraph_IEventStoreInstrumentation pin the contract: implements the interface, defaults disabled, both names flow to the same field in both directions, disabling via either surface unwinds the other. Full CoreTests pass (432/432, 1 unrelated skip). docs/events/projections/async-daemon.md gets a new "Extended Progression Tracking" section that documents both the legacy property and the new interface surface, with the recommendation to prefer the interface for new code. Closes #4686. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4686. Companion to jasperfx#424, which shipped
IEventStoreInstrumentationin JasperFx.Events 2.9.0 as a storage-agnostic surface for CritterWatch's monitoring toggles (starting withExtendedProgressionEnabled).What ships
EventGraphnow implementsIEventStoreInstrumentation. Both names refer to the same underlying field:EnableExtendedProgressionTracking[Obsolete]warning.ExtendedProgressionEnabledIEventStoreInstrumentation. The recommended surface for new code -- letsWolverine.CritterWatch.Marten(and similar satellite packages) flip the toggle viaIConfigureMartenwithout referencing Marten's concreteEventGraph.No schema changes. The six progression columns (
heartbeat,agent_status,pause_reason,running_on_node,warning_behind_threshold,critical_behind_threshold) already exist inmt_event_progressionand the daemon already writes them. Only the API surface changes.Tests
5 new tests in
CoreTests.Events.EventGraph_IEventStoreInstrumentationpin the contract:implements_event_store_instrumentation— the cast succeedsdefault_is_disabled— both names startfalseenabling_via_legacy_name_flows_to_interface_propertyenabling_via_interface_flows_to_legacy_namedisabling_via_either_surface_unwinds_the_otherFull
CoreTestspass (432/432, 1 unrelated skip) on net9.0.Docs
docs/events/projections/async-daemon.mdgets a new "Extended Progression Tracking" section that documents both the legacy property and the new interface, recommends the interface for new code, and notes that the legacy name keeps working.🤖 Generated with Claude Code