[#4454 Phase 2] Default the event store to closed-shape storage#4458
Merged
jeremydmiller merged 1 commit intoMay 18, 2026
Merged
Conversation
Removes UseClosedShapeStorage / MARTEN_USE_CLOSED_SHAPE_STORAGE entirely: the event-document storage adapter is now always ClosedShapeEventDocumentStorage, EventGraph.AttachTypesSynchronously constructs it unconditionally, and the runtime-codegen EventDocumentStorageGenerator + its CodeGenerationExtensions helpers are deleted. The select-stream-state SQL fragment moves to a small StreamStateSql helper that both the closed-shape adapter and the Postgres dialect builders call. Test harness drops the env-var sweep block: OneOffConfigurationsContext / IntegrationContext / DefaultStoreFixture no longer flip the flag after configure(), and TestsSettings.UseClosedShapeStorage is gone. Removes the two redundant closed-shape CI workflow files (jsonnet-pg15 and systemtextjson-pgLatest) — closed-shape is the only path now, so the main event-sourcing lanes cover it. The remaining appending_events_workflow_specs / quick_appending_events_workflow_specs tests that previously asked EventDocumentStorageGenerator for a builder now construct ClosedShapeEventDocumentStorage directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jeremydmiller
deleted the
fix/4454-phase-2-closed-shape-event-store-default
branch
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of #4454. Makes the closed-shape event-document storage adapter the only path and retires the codegen-emitted
EventDocumentStoragegenerator:EventGraph.AttachTypesSynchronouslyconstructsClosedShapeEventDocumentStorageunconditionally. TheUseClosedShapeStorageopt-in (onEventGraphandIEventStoreOptions) is gone.EventDocumentStorageGeneratorand itsCodeGenerationExtensionspartner are deleted.Marten.EventStorage.StreamStateSql.Build(EventGraph)helper that the closed-shape adapter and the Postgres dialect builders share.MARTEN_USE_CLOSED_SHAPE_STORAGE+TestsSettings.UseClosedShapeStorageare deleted, andOneOffConfigurationsContext/IntegrationContext/DefaultStoreFixtureno longer toggle the flag afterconfigure().*-eventsourcing-closed-shape.ymlGH Action workflows are deleted — closed-shape is the only path now, so the main event-sourcing lanes already cover it.appending_events_workflow_specs/quick_appending_events_workflow_specs(the only callers ofEventDocumentStorageGenerator.GenerateStorage) now constructClosedShapeEventDocumentStoragedirectly.Test plan
appending_events_workflow_specs+quick_appending_events_workflow_specs— 52/52 passBug_4411→Bug_4428) — 17/17 passEventSourcingTestssuite — 1333 pass, 5 pre-existing skips, 0 fail (net10.0)Part of #4454. Phase 3 (ancillary stores) is next.
🤖 Generated with Claude Code