Bump JasperFx 1.27 → 1.28.1 + JasperFx.Events 1.30 → 1.31.0 (replaces #4003)#4312
Merged
jeremydmiller merged 1 commit intomasterfrom Apr 28, 2026
Merged
Conversation
Picks up the latest JasperFx + JasperFx.Events. Also bumps the JasperFx.RuntimeCompiler pin to 4.5.0 so the transitive dep set is consistent. JasperFx 1.28 moved the ICodeFile codegen extension methods (notably InitializeSynchronously) into the JasperFx.CodeGeneration namespace (JasperFx/jasperfx#194) and marked the JasperFx.RuntimeCompiler copies [Obsolete]. The new method requires IAssemblyGenerator to be registered in DI (raising a descriptive InvalidOperationException otherwise) -- a deliberate AOT-prep step. Marten currently passes a null IServiceProvider to InitializeSynchronously at four call sites in ProviderGraph, DocumentStore.CompiledQueryCollection, and SecondaryStoreConfig, so the new method's runtime path would throw. Disambiguate by fully-qualifying those four calls to the JasperFx.RuntimeCompiler overload. The Obsolete warning code (CS0618) is already in NoWarn at the repo root, so the explicit qualification stays clean. Proper migration to the new method (registering IAssemblyGenerator in Marten's DI graph) is tracked under the AOT-mode work for Marten 9.0 (issue #4309). Effectively obsoletes PR #4003: the test additions from that PR have already been brought into master via 8ee1d23 ("Add test reproductions from PR #4155 and #4003"), so the only thing left is this package bump and the runtime-compiler disambiguation. The test use_a_single_tenanted_document_in_multi_tenancy_ancillary_store passes against the new package set. Closes #4003. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jeremydmiller
deleted the
replace-pr-4003-single-tenant-doc-in-mt-ancillary
branch
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up the latest JasperFx + JasperFx.Events; also bumps
JasperFx.RuntimeCompilerto 4.5.0 so the transitive set is consistent. Closes #4003 — the test additions in that PR were already brought into master via8ee1d2348(Add test reproductions from PR #4155 and #4003), so the only remaining work was the package bump.One required call-site fix
JasperFx 1.28 moved the
ICodeFilecodegen extension methods — notablyInitializeSynchronously— into theJasperFx.CodeGenerationnamespace (JasperFx/jasperfx#194) and marked theJasperFx.RuntimeCompilercopies[Obsolete]. The new method requiresIAssemblyGeneratorto be registered in DI, which is part of the deliberate AOT-prep work.Marten currently calls
InitializeSynchronouslywithservices: nullat four sites:src/Marten/DocumentStore.CompiledQueryCollection.cs:51src/Marten/Internal/ProviderGraph.cs:62, 81src/Marten/Internal/SecondaryStoreConfig.cs:130The new method's runtime path would throw
InvalidOperationExceptionon those null-services calls. To avoid behavior change in 8.x, this PR fully-qualifies those four calls to theJasperFx.RuntimeCompiler.CodeFileExtensions.InitializeSynchronouslyoverload (which still falls back tonew AssemblyGenerator()).Directory.Build.propsalready suppresses CS0618 (Obsolete), so the explicit qualification doesn't generate noise.Proper migration — registering
IAssemblyGeneratorin Marten's DI graph and switching to the new namespace's method — is tracked as part of the AOT-friendly mode work in #4309.Test plan
use_a_single_tenanted_document_in_multi_tenancy_ancillary_store) — 8 passedend_to_end_event_capture_and_fetching_the_stream+archiving_events)🤖 Generated with Claude Code