Fix ProjectionVersion suffix being overwritten by explicit DocumentAlias#4299
Merged
jeremydmiller merged 2 commits intoJasperFx:masterfrom Apr 28, 2026
Conversation
When a projection sets ProjectionVersion > 1, the document alias should
be suffixed with "_N" so the new version is rebuilt into a parallel
mt_doc_xxx_N table (per the documented blue/green deployment pattern).
However, when the user supplies an explicit alias via
Schema.For<T>().DocumentAlias("...") or [DocumentAlias("...")],
that alias was applied AFTER the policy ran, silently overwriting
the version suffix. The new shard would then attempt to rebuild into
the v1 table and crash on existing v1 documents that lack newly-added
fields.
Split the alias-suffix step out of ProjectionDocumentPolicy into a new
ProjectionVersionAliasPolicy registered as a post-policy. Post-policies
run from StorageFeatures.MappingFor AFTER the fluent builder alterations,
so the suffix lands on whatever alias the user actually configured. The
remaining Marten-managed defaults (UseOptimisticConcurrency=false,
UseNumericRevisions=true, ConfigureAggregateMapping) stay in the
pre-policy and continue to win against earlier user-supplied policies.
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a projection sets ProjectionVersion > 1, the document alias should be suffixed with "_N" so the new version is rebuilt into a parallel mt_doc_xxx_N table (per the documented blue/green deployment pattern). However, when the user supplies an explicit alias via Schema.For().DocumentAlias("...") or [DocumentAlias("...")], that alias was applied AFTER the policy ran, silently overwriting the version suffix. The new shard would then attempt to rebuild into the v1 table and crash on existing v1 documents that lack newly-added fields.
Split the alias-suffix step out of ProjectionDocumentPolicy into a new ProjectionVersionAliasPolicy registered as a post-policy. Post-policies run from StorageFeatures.MappingFor AFTER the fluent builder alterations, so the suffix lands on whatever alias the user actually configured. The remaining Marten-managed defaults (UseOptimisticConcurrency=false, UseNumericRevisions=true, ConfigureAggregateMapping) stay in the pre-policy and continue to win against earlier user-supplied policies.