Ensure ExistingStreamIdCollisionException is thrown when UseArchivedStreamPartitioning is enabled#4287
Closed
mfmadsen wants to merge 1 commit intoJasperFx:masterfrom
Closed
Ensure ExistingStreamIdCollisionException is thrown when UseArchivedStreamPartitioning is enabled#4287mfmadsen wants to merge 1 commit intoJasperFx:masterfrom
mfmadsen wants to merge 1 commit intoJasperFx:masterfrom
Conversation
…treamPartitioning is enabled.
erdtsieck
approved these changes
Apr 24, 2026
gfoidl
reviewed
Apr 24, 2026
|
|
||
| private static bool matches(Exception e) | ||
| { | ||
| { |
Contributor
There was a problem hiding this comment.
Nit: undo the whitespace change
Suggested change
| { | |
| { |
Member
|
@mfmadsen I'm going to add a couple more test cases afterward if this successfully lands. I'll be pleasantly surprised if this is really enough |
Contributor
Author
|
@jeremydmiller, sounds good. See my comment on the issue for another somewhat related issue, that might be important to have in mind as well if you are expanding the PR. |
Member
|
This is superseded by #4293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion on a fix for issue #4286