GH-4272: Allows ValueTypesto be used as Duplicated Fields#4274
Merged
jeremydmiller merged 4 commits intoJasperFx:masterfrom Apr 22, 2026
Merged
GH-4272: Allows ValueTypesto be used as Duplicated Fields#4274jeremydmiller merged 4 commits intoJasperFx:masterfrom
jeremydmiller merged 4 commits intoJasperFx:masterfrom
Conversation
This was referenced Apr 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ValueTypes used as Duplicated Fields would cause a compilation failure at runtime.
Issue explained in detail in: #4272
Solution
Added support for
ValueTypemembers to be used as Duplicated Fields.DuplicatedValueTypeFieldclass that encapsulates theValueType-specific logic for generating correct upsert parameter code, unwrapping the inner primitiveValueinstead of passing the ValueType wrapper directly.DocumentMappingto detect when a duplicated member implementsIValueTypeMember<,>and instantiateDuplicatedValueTypeFieldinstead of the standardDuplicatedField, using the registeredValueTypeInfofromStoreOptions.ValueTypes.CreateComparison(...)method to correctly handle LINQ query comparisons against duplicatedValueTypefields.Tests
ValueTypefields using Vogen and StronglyTypedId value objects.