Fix integer out of range in mt_quick_append_events and mt_get_next_hi SQL functions#4248
Merged
jeremydmiller merged 1 commit intoJasperFx:masterfrom Apr 14, 2026
Merged
Conversation
… SQL functions The mt_quick_append_events function declared its return type and internal variables as int/int[] while the underlying sequence (mt_events_sequence) and seq_id column use bigint. This causes integer overflow when sequence IDs exceed ~2.1 billion, which was observed in production. Changed in mt_quick_append_events: - RETURNS int[] → bigint[] - event_version int → bigint - seq int → bigint - return_value int[] → bigint[] Also fixed mt_get_next_hi which declared RETURNS integer despite its hi_value column being bigint and its internal variables being bigint. C# consumers already read these values as long/long[], so no client-side changes are needed. A test is added that advances the event sequence past int.MaxValue and verifies quick append still works correctly.
jeremydmiller
added a commit
that referenced
this pull request
Apr 14, 2026
The Bug_4246 test from PR #4248 sets the sequence above int32 max but didn't enable EnableBigIntEvents, causing the mt_quick_append_events function to overflow with its default int types. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mt_quick_append_events function declared its return type and internal variables as int/int[] while the underlying sequence (mt_events_sequence) and seq_id column use bigint. This causes integer overflow when sequence IDs exceed ~2.1 billion, which was observed in production.
Changed in mt_quick_append_events:
Also fixed mt_get_next_hi which declared RETURNS integer despite its hi_value column being bigint and its internal variables being bigint.
C# consumers already read these values as long/long[], so no client-side changes are needed. A test is added that advances the event sequence past int.MaxValue and verifies quick append still works correctly.
This fixes bug: #4246