Quote column names in DuplicatedField UpdateSqlFragment (with test fixes)#4242
Merged
jeremydmiller merged 4 commits intomasterfrom Apr 8, 2026
Merged
Conversation
…agment Update all test expectations to include double-quoted column names, matching the change in DuplicatedField.UpdateSqlFragment() from PR #4237 that unconditionally quotes column names to handle PostgreSQL reserved keywords (e.g., "offset"). 26/26 DuplicatedFieldTests passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When ColumnName is set to PascalCase (e.g., "String"), quoting it as "String" makes PostgreSQL treat it case-sensitively, failing to match the actual lowercase column. Apply ToLowerInvariant() before quoting. Fixes the duplicated_fields_only_update_when_nested_source_is_modified test failure where columnName: "String" was quoted as "String" but the actual column is lowercase string. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on PR #4237 by @Brar — quotes column names in
DuplicatedField.UpdateSqlFragment()to handle PostgreSQL reserved keywords (e.g.,offset).This PR includes the original changes from #4237 plus fixes for the 26 failing
DuplicatedFieldTeststhat expected unquoted column names.Changes
DuplicatedField.UpdateSqlFragment()now wrapsColumnNamein double quotes (from Quote column names in DuplicatedField update fragments #4237)DuplicatedFieldTestsexpectations updated to expect"column_name"instead ofcolumn_nameSupersedes #4237
Test plan
🤖 Generated with Claude Code