Fix long identifier names exceeding PostgreSQL NAMEDATALEN limit#4235
Merged
jeremydmiller merged 1 commit intomasterfrom Apr 6, 2026
Merged
Fix long identifier names exceeding PostgreSQL NAMEDATALEN limit#4235jeremydmiller merged 1 commit intomasterfrom
jeremydmiller merged 1 commit intomasterfrom
Conversation
Apply PostgresqlIdentifier.Shorten() (from Weasel 8.12.0) to all dynamically generated FK, PK, and index names in EventTagTable and NaturalKeyTable. When names exceed 63 chars, they are deterministically truncated with a 4-char FNV-1a hash suffix to avoid collisions. Fixes the scenario from #4224: auto-discovered tag types with long names generating identifiers like "fkey_mt_event_tag_bootstrap_token_resource_ name_seq_id_is_archived" (69 chars) that exceed the limit. Also upgrades Weasel.Postgresql and Weasel.EntityFrameworkCore to 8.12.0. Closes #4224 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremydmiller
force-pushed
the
fix/4224-long-identifier-hashing
branch
from
a0aac8e to
622eb91
Compare
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgresqlIdentifier.Shorten()to all dynamically generated FK, PK, and index names inEventTagTableandNaturalKeyTableFixes #4224 — auto-discovered tag types with long names (e.g.,
BootstrapTokenResourceName) generated FK names exceeding 63 chars, causingPostgresqlIdentifierTooLongExceptionat startup.Depends on JasperFx/weasel#241
Test plan
🤖 Generated with Claude Code