8.28.0: CritterWatch support — IDynamicTenantSource, threshold columns, source generator#4220
Merged
jeremydmiller merged 7 commits intomasterfrom Mar 31, 2026
Merged
8.28.0: CritterWatch support — IDynamicTenantSource, threshold columns, source generator#4220jeremydmiller merged 7 commits intomasterfrom
jeremydmiller merged 7 commits intomasterfrom
Conversation
…ove/enable and cache eviction
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…Gets IDynamicTenantSource on MasterTableTenancy, threshold columns, Marten.SourceGeneration, switched back to NuGet PackageReferences. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…n in cross-project tests Two issues fixed: 1. Skip ID type validation for natural key aggregates in SingleStreamProjection.validateDocumentIdentity(). Natural key aggregates intentionally have an ID type that differs from the stream identity type (e.g., string ID with Guid streams). 2. Limit DiscoverNaturalKeyAggregates to ApplicationAssembly only, not all loaded assemblies. When test projects share compile references, aggregates from other projects with incompatible stream identity types were being auto-registered and failing validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ation Three fixes for CI failures on the critterwatch branch: 1. NaturalKeyTable: explicit ISchemaObject.WriteCreateStatement override wraps FK creation in DO $$ IF NOT EXISTS guard and indexes with IF NOT EXISTS to prevent "constraint/index already exists" errors when CREATE TABLE IF NOT EXISTS is a no-op. 2. SingleStreamProjection.validateDocumentIdentity: skip ID type validation when NaturalKeyDefinition is set, since natural key aggregates intentionally have IDs that differ from stream identity. 3. Remove DiscoverNaturalKeyAggregates assembly scanning from DocumentStore initialization. Natural keys are discovered lazily via FetchForWriting. Assembly scanning caused spurious projection registration that broke subscription count assertions and caused InvalidProjectionException in cross-project test configurations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Generated with Claude Code