Fix FetchForWriting with UseIdentityMapForAggregates and strongly typed IDs#4216
Merged
jeremydmiller merged 1 commit intomasterfrom Mar 28, 2026
Merged
Conversation
…ates and strongly typed IDs When UseIdentityMapForAggregates is true and the aggregate uses a strongly typed ID (e.g., PaymentId wrapping Guid), the identity map would be populated by the inline projection using the strong-typed key (Dictionary<PaymentId, Payment>), but FetchForWriting would try to cast it to Dictionary<Guid, Payment>, causing an InvalidCastException. The fix makes StoreDocumentInItemMap gracefully skip storing when the existing dictionary has an incompatible key type — the document is already present from the inline projection's storage path. Closes #4214 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremydmiller
added a commit
to JasperFx/polecat
that referenced
this pull request
Mar 28, 2026
…ates and strongly typed IDs Port of JasperFx/marten#4216. When UseIdentityMapForAggregates is true and the aggregate uses a strongly typed ID (e.g., PaymentId wrapping Guid), the identity map dictionary key type mismatch caused an InvalidCastException. The fix makes StoreAggregateInIdentityMap gracefully skip when the existing dictionary has an incompatible key type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merged
2 tasks
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidCastException: Unable to cast object of type 'Dictionary<PaymentId,Payment>' to type 'Dictionary<Guid,Payment>'when usingFetchForWriting()withUseIdentityMapForAggregates = trueand aggregates that have strongly typed IDs (via StronglyTypedId, Vogen, etc.)PaymentId), butFetchForWritingtries to access it using the raw stream identity type (Guid). The fix makesStoreDocumentInItemMapgracefully skip when the existing dictionary has an incompatible key type, since the document is already present from the projection's storage path.Closes #4214
Test plan
nuke compile🤖 Generated with Claude Code