Fix for #4185: duplicate codegen for secondary store impl#4209
Merged
jeremydmiller merged 2 commits intoJasperFx:masterfrom Mar 27, 2026
Merged
Conversation
…tore impl Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…Config.Build() CreateGenerationRules() appends StoreName to the output path, but SecondaryDocumentStores.Rules (used by codegen write) strips it via ParentDirectory(). This mismatch caused the same store implementation class to be written to two different directories with the same namespace, resulting in CS0101 duplicate type errors with TypeLoadMode.Static. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
erdtsieck
changed the title
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might also fix #4186
But proof that it fixes #4185