Fix F# record projection casing in GroupJoin/SelectMany#4196
Merged
jeremydmiller merged 1 commit intomasterfrom Mar 23, 2026
Merged
Fix F# record projection casing in GroupJoin/SelectMany#4196jeremydmiller merged 1 commit intomasterfrom
jeremydmiller merged 1 commit intomasterfrom
Conversation
F# records have camelCase constructor parameters but PascalCase properties. SelectParser and JoinSelectParser used constructor parameter names for jsonb_build_object keys, causing STJ deserialization to fail for F# records. Now prefers NewExpression.Members when available, then falls back to matching properties by position for types like F# records where param/property names differ only in casing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremydmiller
force-pushed
the
fix/4182-fsharp-option-linq
branch
from
fb4f37c to
97a4355
Compare
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupJoin/SelectManyfail with STJ due to constructor parameter casing mismatchuserId,firstName) but PascalCase properties (UserId,FirstName). Marten'sSelectParserandJoinSelectParserused constructor param names forjsonb_build_objectkeys, producing JSON like{"userId": ...}that STJ's F# record converter can't deserialize (expects{"UserId": ...})SelectParser.ResolveFieldName()that prefersNewExpression.Memberswhen available (C# anonymous types), then falls back to matching properties by position for F# recordsSelectParser.VisitNew()andJoinSelectParser.VisitNew()Test plan
Bug_4182_fsharp_record_projection_casingwith both STJ and Newtonsoft testsBulkLoaderconnection issue that passes in isolation)🤖 Generated with Claude Code