Skip to content

Fix NullReferenceException in EnrichUsingEntityQuery cache handling #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Feb 16, 2026
Merged

Fix NullReferenceException in EnrichUsingEntityQuery cache handling #4144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/DaemonTests/TeleHealth/AppointmentDetailsProjection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,14 @@ await group
}

// Try to resolve RoutingReason documents from the cache first
var missingCodes = reasonCodes.Where(code => !cache.TryFind(code, out _)).ToList();
// Note: cache may be null when there is no upstream aggregate cache for the entity type
var missingCodes = cache != null
? reasonCodes.Where(code => !cache.TryFind(code, out _)).ToList()
: reasonCodes.ToList();

// Only query the database for codes that are not yet cached
// Use a local dictionary for lookups when cache is unavailable
var localLookup = new Dictionary<string, RoutingReason>();
if (missingCodes.Count > 0)
{
var reasonsFromDb = await querySession
Expand All @@ -100,10 +105,11 @@ await group
.Where(r => r.IsActive)
.ToListAsync(ct);

// Store fetched documents in the cache for reuse
// Store fetched documents in the cache (if available) and local lookup for reuse
foreach (var reason in reasonsFromDb)
{
cache.Store(reason.Code, reason);
cache?.Store(reason.Code, reason);
localLookup[reason.Code] = reason;
}
}

Expand All @@ -120,7 +126,8 @@ await group

foreach (var code in codesInSlice)
{
if (cache.TryFind(code, out var reason))
if ((cache != null && cache.TryFind(code, out var reason)) ||
localLookup.TryGetValue(code, out reason))
{
slice.Reference(reason);
}
Expand Down
Loading