Remove diagnostic ITestOutputHelper/TestOutputMartenLogger from tests#4136
Merged
jeremydmiller merged 7 commits intomasterfrom Feb 15, 2026
Merged
Remove diagnostic ITestOutputHelper/TestOutputMartenLogger from tests#4136jeremydmiller merged 7 commits intomasterfrom
jeremydmiller merged 7 commits intomasterfrom
Conversation
… tests Remove ITestOutputHelper constructor injection and TestOutputMartenLogger diagnostic logging from ~120 test files across CoreTests, DocumentDbTests, EventSourcingTests, LinqTests, MultiTenancyTests, PatchingTests, and ValueTypeTests. These were only used for diagnostic SQL output and added unnecessary constructor parameters and fields. The TestOutputMartenLogger class itself is preserved for DaemonTests/StressTests usage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move the foreign_keys test class from DocumentDbTests/ForeignKeys to CoreTests/ForeignKeys. Add deadlock detection retry logic to OneOffConfigurationsContext.StoreOptions() - on PostgreSQL deadlock (40P01), wait 250ms and retry once before failing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the DeleteAllDocuments/DeleteAllEventData calls from IntegrationContext.InitializeAsync() to improve test performance. Add targeted ResetAllData calls only where tests actually need clean state: via fixtureSetup() overrides for classes where all tests fail, and at individual test level for partial failures. Also adds deadlock retry logic to OneOffConfigurationsContext.StoreOptions() and moves foreign_keys tests from DocumentDbTests to CoreTests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ant cleanup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…lays) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…outs - Replace per-test CompletelyRemoveAllAsync with per-test schema drop via IAsyncLifetime in Using_Global/Local_DocumentSessionListener_Tests - Reduce all WaitForNonStaleData timeouts exceeding 15s down to 15s (was 30s, 60s, 120s across 6 files) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Share a single DocumentStore/IHost across all partition management tests instead of creating a new store per test via StoreOptions(). Uses schema drop + ResetSchemaExistenceChecks() in InitializeAsync to ensure clean partition state between tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ITestOutputHelperconstructor injection andTestOutputMartenLoggerdiagnostic logging from ~120 test files across 7 test projects (CoreTests, DocumentDbTests, EventSourcingTests, LinqTests, MultiTenancyTests, PatchingTests, ValueTypeTests)TestOutputMartenLoggerclass itself is preserved for DaemonTests/StressTests usageforeign_keystest class from DocumentDbTests to CoreTestsOneOffConfigurationsContext.StoreOptions()to handle transient PostgreSQL 40P01 errorsDeleteAllDocuments/DeleteAllEventDatafromIntegrationContext.InitializeAsync()to improve test performanceResetAllData()calls only where tests actually need clean state: viafixtureSetup()overrides for classes where all tests depend on it, and at individual test level for partial casesResetAllData()calls intofixtureSetup()overrides in 3 DocumentDbTests files (streaming_json_results, query_by_sql, ejecting_documents) — replacing 52 individual calls with 3 class-level overridesIAsyncLifetimetoarchiving_events.cswithDeleteAllEventDataAsync()inInitializeAsync(), removing 6 redundant per-test cleanup callsquick_append_timestamptest file — dead code containing 35 seconds ofTask.Delaycalls in a commented-out[Fact]CompletelyRemoveAllAsync()with per-test schema drop viaIAsyncLifetimeinUsing_Global/Local_DocumentSessionListener_Tests(21 calls removed)WaitForNonStaleDatatimeouts exceeding 15 seconds down to 15s (was 30s, 60s, 120s across 6 EventSourcingTests files)marten_managed_tenant_id_partitioningtests fromOneOffConfigurationsContextto sharedStoreFixturepattern, sharing a single DocumentStore/IHost across all 8 partition management testsTest plan
🤖 Generated with Claude Code