feat: add dictionary patching support (Increment, Append, Remove by key) #4062
+479
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That's about the nastiest, hardest area of the Marten codebase to go into. Patching code looks good, but that introduced a regression in the LINQ support we'll need to figure out before this can go out,. |
kyle69
force-pushed
the
feat/patching-dictionary
branch
from
beea165 to
f9a1cf7
Compare
Contributor
Author
I pushed a fix :) |
Support for patching Dictionary<TKey, TValue> properties using indexer syntax.
kyle69
force-pushed
the
feat/patching-dictionary
branch
from
f9a1cf7 to
0ea401a
Compare
Contributor
Author
|
@jeremydmiller I'm following up on this—were you able to look into the build error issue? |
Member
|
Hey @kyle69 I will take a look and keep you posted sometime this week. |
Member
|
@kyle69 @babuannamalai I'm pulling this in locally to check out what's up w/ LINQ and get this in |
Member
|
Looks good locally |
This was referenced Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for patching Dictionary<TKey, TValue> properties using indexer syntax.